Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix directory names #230

Closed
wants to merge 2 commits into from
Closed

fix directory names #230

wants to merge 2 commits into from

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Sep 14, 2020

  • Updated changelog.

@yihuang yihuang changed the title fix directory names and remove patching cli code fix directory names Sep 14, 2020
@yihuang yihuang mentioned this pull request Sep 14, 2020
Merged
ilgooz
ilgooz reviewed Sep 19, 2020
View reviewed changes
starport/services/serve/plugin-stargate.go
@@ -84,7 +84,7 @@ func (p *stargatePlugin) PostInit() error {
if err != nil {
return err
}
path := filepath.Join(home, p.app.nd(), "config/app.toml")
path := filepath.Join(home, fmt.Sprintf(".%s/config/app.toml", p.app.nd()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, as I'm aware, Stargate uses non-dot files to keep app data under home. Maybe I'm missing something, have you noticed that if any dot files generated by a Stargate app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I find that it's we changed the directory ourself, I tried with a new test project, no issue exists, I'll close this.

@yihuang yihuang closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz left review comments

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @ilgooz