docs: Add v0.18 migration #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeev
requested review from
alijnmerchant21,
barriebyron,
soniasingla and
toschdev
barriebyron
reviewed
Sep 21, 2021
fadeev
commented
Sep 21, 2021
blockchain template Co-authored-by: Denis Fadeev <[email protected]>
barriebyron
reviewed
Sep 21, 2021
barriebyron
reviewed
Sep 21, 2021
submitting changes to clarify reason and actions
barriebyron
reviewed
Sep 21, 2021
barriebyron
previously approved these changes
Sep 22, 2021
Co-authored-by: Barrie Byron <[email protected]>
Co-authored-by: Barrie Byron <[email protected]>
Co-authored-by: Barrie Byron <[email protected]>
|
This looks LGTM to me apart from my comment above👍 Maybe we can add |
|
@lubtd thanks! Reverted back to |
lumtis
previously approved these changes
Sep 24, 2021
|
@Pantani good catch about the BandChain support, added! Also, merged changes from |
lumtis
previously approved these changes
Sep 24, 2021
Pantani
previously approved these changes
Sep 24, 2021
Pantani
reviewed
Sep 24, 2021
lumtis
approved these changes
Sep 27, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* Add v0.18 migration * Tabs to spaces * add a description of migration requirements and context of why needed * Update docs/migration/index.md blockchain template Co-authored-by: Denis Fadeev <[email protected]> * Apply suggestions from code review submitting changes to clarify reason and actions * Update docs/migration/index.md add missing blank line * Intro * Add go.mod * Update docs/migration/index.md Co-authored-by: Barrie Byron <[email protected]> * Update docs/migration/index.md Co-authored-by: Barrie Byron <[email protected]> * Update docs/migration/index.md Co-authored-by: Barrie Byron <[email protected]> * Update docs/migration/index.md Co-authored-by: Lucas Bertrand <[email protected]> * remove extra ``go * NewClientProposalHandler * Update docs/migration/index.md Co-authored-by: Tobias Schwarz <[email protected]> * Add app.appCodec as an argument * Keep `tmjson` * Move `go.mod` higher * BandChain support * If mars is an IBC-module Co-authored-by: Barrie Byron <[email protected]> Co-authored-by: Barrie Byron <[email protected]> Co-authored-by: Lucas Bertrand <[email protected]> Co-authored-by: Tobias Schwarz <[email protected]> Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1575
These are the changes a dev needs to make to the default v0.17.3 template for it to be compatible with Cosmos SDK v0.44 and Starport v0.18.
We'll print a link to this guide when a user uses Starport v0.18, but has a pre-v0.44 version in
go.mod.