feat(scaffolding): add --path for all scaffold, generate and chain commands
#1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
reviewed
Aug 30, 2021
There was a problem hiding this comment.
@Pantani can you also cover this part? #1365 (comment)
to detect, we can recursively lookup for a go.mod file in parent directories. and to make sure this belongs to the chain, let's check if the go.mod file requires tendermint and cosmos-sdk repositories. then we can set the dir of where go.mod resides as the --path, otherwise we can return with an error.
great, nice feature!! it's done |
…pp-path-flag # Conflicts: # starport/services/scaffolder/oracle.go # starport/services/scaffolder/packet.go
ilgooz
requested changes
Sep 2, 2021
ilgooz
requested changes
Sep 8, 2021
lumtis
previously approved these changes
Sep 9, 2021
ilgooz
requested changes
Sep 9, 2021
lumtis
previously approved these changes
Sep 10, 2021
ilgooz
approved these changes
Sep 13, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…ignite#1518) * add appPath flag for all scaffold, generate and chain commands * use app path flag as a constant * fix the wrong proto path * add dynamic path for box templates * add aPath parameter to AddGenesisTest method * fix box walk path * fix new chain path * fix protoc generation * improva code readbility * fix import sort for run.go * add dynamic search for go module in the parent directories * fix TestParse method * check if the the cosmos-sdk and the tendermint packages are imported * print the relative scaffold paths * apply comment suggestions from PR * don't use Path structure to path the appPath var * Apply suggestions from code review * fix some relative paths and remove unused method context * move ValidateGoModule method * fix lint * fix appPath for scaffold wasm * remove global app path * fix merge conflicts * move ValidateGoMod method to cosmosanalysis package * fix missing path flag * remove unused error return * fix path for genesis types test modifiers * improve app path description and removed unused flag * change AppPath flag to Path * avoid generic path flag * remove gomodulepath import from the cosmosanalysis pkg * fix wrong app path * remove unecessary conversion to absPath * add integration test cases for custom app path * move relative path method to cmd * create ValidateApp extension method for Scaffolder object and remove newChain method * fix wrong method call * add test path with a folder inside the project * refactor(scaffolder): w/ --path (ignite#1568) Co-authored-by: İlker G. Öztürk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1365
What does this MR does?
Add the --path flag for all starport scaffolds, generate and chain commands.
How to test?