-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): scaffold genesis validation tests #1489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
reviewed
Aug 25, 2021
Pantani
reviewed
Aug 25, 2021
Pantani
previously approved these changes
Aug 25, 2021
Didn't mean to dismiss your review @Pantani 😬 just added a line to the changelog. |
fadeev
previously approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💪
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* Initialize test template * Add placeholder * Genesis test patch * map test case * Small fix * list genesis tests * Small fix * Template fixes * lint template * Lint * Small fix template * Small fix template * Valid case tests * Lint * docs: update changelog * Fix issue with ibc Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Denis Fadeev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a module is scaffolded with
starport s module
a filex/.../types/genesis_test.go
is created for genesis validation testsThis file contains a initial test that is the default genesis must be valid
Additional test cases are automatically added for the following command:
map
: check there cannot be duplicated index in the genesislist
: check there cannot be duplicated id in the genesis and count must be higher than the biggest idgenesis_test.go
is created with the above command if it doesn't exist for compatibility with older scaffolded module