Standardize ratings review counts #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When showing the histogram, we should always show the total number of ratings that factored into the histogram, and we should juxtapose that number with the number of written reviews, because these numbers are confusingly similar ideas. This fixes https://github.com/iftechfoundation/ifdb-suggestion-tracker/issues/475 where the `?ratings` view would show `$rowcnt` as the number of ratings, which might not match `$ratingCntAvg`.
You can access the `viewgame` game listing page with these modes: * `?reviews`: Show all written member reviews * `?ratings`: Show all of the ratings that factored into the average * `?review=####`: Show just a single review Rather than showing "Ratings and Reviews" for all of these cases, we'll now show a more specific header depending on the review mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of bugs, including #404 and #502.