Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allowing VASP files without standard names #8

Closed
joerivan opened this issue Sep 11, 2024 · 4 comments
Closed

Feature request: Allowing VASP files without standard names #8

joerivan opened this issue Sep 11, 2024 · 4 comments

Comments

@joerivan
Copy link

The standard files used by VASP which are read by atom-architect are POSCAR CONTCAR and OUTCAR files. Sometimes when working with multiple VASP files it is easy to slightly change the names of these files like POSCAR_1, CONTCAR.final, or OUTCAR_last.

I would thus suggest that atom-architect could import, or try to import, files even if they do not posses the standard VASP names.

The Geometry optimization analysis tab already supports these multiple types of OUTCAR file name changes.

ifilot added a commit that referenced this issue Sep 11, 2024
@ifilot ifilot mentioned this issue Sep 11, 2024
ifilot added a commit that referenced this issue Sep 12, 2024
* Fixing menu items w.r.t. issue #4

* Fixing issue #8

* Initial commit CLI

* Implementing NEB analysis via CLI

* Updating README.md

* Creating patch file for Qt5

* Fixing compilation instructions

* Fixing compilation instructions

* Fixing bug in info widget
@joerivan
Copy link
Author

Files starting with POSCAR CONTCAR and OUTCAR can be opened since Patch 0.2.3

The only thing that might be missing is that these variations on the standard files do not yet appear in the File -> Open prompt, the files manager does not recognize them as valid input files.

@ifilot
Copy link
Owner

ifilot commented Sep 13, 2024

I am unable to reproduce this (see example below). Can you share some further details where this is exactly occurring?

image

@joerivan
Copy link
Author

It only appears to be a problem for me in the Geometry optimization analysis window. In this folder, I also have OUTCAR files with different names. Indeed for the normal viewer, the files do appear.

Screenshot fileexplorer

@ifilot ifilot mentioned this issue Sep 13, 2024
ifilot added a commit that referenced this issue Sep 13, 2024
* Adding CLI arguments w.r.t. issue #9

* Changing filename loading pattern in geometry analysis window w.r.t. issue #8
@ifilot
Copy link
Owner

ifilot commented Sep 13, 2024

The problem should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants