Skip to content

Commit

Permalink
Require CGI in HTTP Instrumentation module
Browse files Browse the repository at this point in the history
HTTP Instrumentation module uses CGI to escape URL. This will prevent
issues when using Hawk and CGI has not been already loaded by
third-party dependencies

E.g.:
```
$ bin/console
> Hawk::HTTP.new('http://example.com/').get('/')
NameError (uninitialized constant Hawk::HTTP::Instrumentation::Basic::CGI)
```
  • Loading branch information
tagliala committed Jan 21, 2024
1 parent 65ce5da commit 0c95980
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/hawk/http/instrumentation.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require 'cgi'

module Hawk
class HTTP
module Instrumentation
Expand Down

0 comments on commit 0c95980

Please sign in to comment.