-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subprotocol negotiation #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall SGTM
copybara-service bot
pushed a commit
to google/quiche
that referenced
this pull request
Nov 16, 2023
Based on ietf-wg-webtrans/draft-ietf-webtrans-http3#144 PiperOrigin-RevId: 583029408
ekinnear
reviewed
Nov 28, 2023
Co-authored-by: Eric Kinnear <[email protected]>
ekinnear
approved these changes
Nov 28, 2023
Co-authored-by: David Schinazi <[email protected]>
Co-authored-by: David Schinazi <[email protected]>
DavidSchinazi
approved these changes
Dec 12, 2023
Discussed with David at the Editor's Meeting. Made server replying optional, as otherwise it is impossible to migrate the same endpoint from not using a subprotocol to using one. |
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137