add EditionDisplay to give human readable names to chapter editions #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
format addition
spec_main
|
Which edition name(string) should be used if there is an |
I created #655 to fix this issue which also exists for other elements and needs to be handled independently from this PR. |
retokromer
approved these changes
Jul 31, 2022
When there are multiple editions it should make it easier to pick one for the user. Otherwise tags with TagEditionUID as the target might be sufficient and more versatile. Fixes #300
|
Merging this as it's for Matroska v5 and won't affect the specs of Matroska v1 ot v4. |
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Sep 11, 2022
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Sep 11, 2022
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Sep 18, 2022
robUx4
added a commit
to Matroska-Org/foundation-source
that referenced
this pull request
Sep 18, 2022
robUx4
added a commit
to Matroska-Org/foundation-source
that referenced
this pull request
Sep 18, 2022
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Sep 18, 2022
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Sep 18, 2022
robUx4
added a commit
to Matroska-Org/foundation-source
that referenced
this pull request
Oct 2, 2022
robUx4
added a commit
to Matroska-Org/foundation-source
that referenced
this pull request
Oct 2, 2022
robUx4
added a commit
to Matroska-Org/foundation-source
that referenced
this pull request
Oct 2, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple editions it should make it easier to pick one for the user.
Otherwise tags with TagEditionUID as the target might be sufficient and more versatile.
Fixes #300