minor bug fixes

iemre · Dec 28, 2015 · 27ee9fa · 27ee9fa
1 parent 900b6d0
commit 27ee9fa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/AbstractExperiment.m b/AbstractExperiment.m
@@ -96,6 +96,9 @@ function setupSizes(obj)
                 hit = 0;
                 fprintf('Iteration %d\n', i);
                 topNList = obj.generateTopNListForTestSetForUser(n, userIndex);
+                if isempty(topNList)
+                    continue;
+                end
                 obj.result.increaseItemHitsInList(topNList);
                 i = i + 1;
 
@@ -127,7 +130,7 @@ function setupSizes(obj)
 
         function time = timeOnePrediction(obj, userIndex, itemIndex)
             tic;
-            obj.calculateFullPrediction(userIndex, itemIndex);
+            obj.makePrediction(userIndex, itemIndex);
             time = toc;
         end
 
@@ -181,7 +184,7 @@ function setupSizes(obj)
             end
 
             cpp = totalCpp / countUser;
-            obj.result.CPP = cpp;
+            obj.result.cppRate = cpp;
             disp(obj.result);
         end
 

diff --git a/KNN/ItemBasedKNN.m b/KNN/ItemBasedKNN.m
@@ -203,10 +203,6 @@
         end
 
         function obj = calculateSimilaritiesUsingMatlabKNN(obj)
-            if isempty(obj.similarities) == 0
-                return;
-            end
-
             for itemIndex = 1:obj.itemCount
                 fprintf('Calculating similar items to item %d\n', itemIndex);
                 [neighbourIndexes, distances] = knnsearch(obj.baseSet', obj.baseSet(:, itemIndex)', 'distance', 'correlation', 'k', obj.itemCount);

diff --git a/SparseCoding/ItemBasedSparseCoderExperiment.m b/SparseCoding/ItemBasedSparseCoderExperiment.m
@@ -518,7 +518,7 @@ function initialize(obj)
 
             ratings = obj.reconstruction(userIndex, :);
             [~, topList] = sort(ratings, 'descend');
-            topNList = zeros(1, n);
+            topNList = [];
             k = 1;
             for itemIndex = topList
                 if UIMatrixUtils.userHasRatedItem(obj.baseSet,userIndex,itemIndex,obj.nilElement)