Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix determineState of ThermalHouse #927

Merged
merged 15 commits into from
Aug 28, 2024
Merged

Fix determineState of ThermalHouse #927

merged 15 commits into from
Aug 28, 2024

Conversation

danielfeismann
Copy link
Member

resolves #926

@danielfeismann danielfeismann self-assigned this Aug 24, 2024
@danielfeismann danielfeismann added the bug Something isn't working label Aug 24, 2024
This was referenced Aug 24, 2024
Merged
Open
sebastian-peter
sebastian-peter reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now I totally unterstand what you meant. Thanks for providing this fix!

Not sure if we need a test for this? Maybe testing ThermalHouse#determineState?

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalHouse.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalHouse.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala Outdated Show resolved Hide resolved
danielfeismann and others added 11 commits August 28, 2024 17:31
@danielfeismann @sebastian-peter
Update src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
f1ef8ba 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Update src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
35c3588 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
d65d32e 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Update src/main/scala/edu/ie3/simona/model/thermal/ThermalHouse.scala
4bc685e 
Include reviewers suggestion

Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
77cd171 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
2591a3d 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
16ecbb9 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
8022318 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
e81015f 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann @sebastian-peter
Include reviewers suggestion
4d0aaa8 
Co-authored-by: Sebastian Peter <[email protected]>
@danielfeismann
Merge branch 'dev' into df/#926-Fix-determineState-of-ThermalHouse
11a559b
@danielfeismann
Copy link
Member Author

Ok now I totally unterstand what you meant. Thanks for providing this fix!

Not sure if we need a test for this? Maybe testing ThermalHouse#determineState?

Most probably: yes. I will add one.

danielfeismann and others added 2 commits August 28, 2024 18:09
sebastian-peter
sebastian-peter approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastian-peter sebastian-peter merged commit b870fe7 into dev Aug 28, 2024
4 checks passed
@sebastian-peter sebastian-peter deleted the df/#926-Fix-determineState-of-ThermalHouse branch August 28, 2024 16:52
@sebastian-peter sebastian-peter mentioned this pull request Aug 28, 2024
Closed
@danielfeismann danielfeismann mentioned this pull request Aug 29, 2024
Closed
@sebastian-peter sebastian-peter linked an issue Aug 29, 2024 that may be closed by this pull request
Provide actual ambient temperature of tick to HpModel when calculate state #882
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@jo-bao jo-bao Awaiting requested review from jo-bao

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@danielfeismann @sebastian-peter