Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge HpTestData and HpModelTestData #873

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Merge HpTestData and HpModelTestData #873

merged 7 commits into from
Aug 12, 2024

Conversation

danielfeismann
Copy link
Member

resolves #872

@danielfeismann danielfeismann self-assigned this Jul 31, 2024
@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Jul 31, 2024
@danielfeismann danielfeismann marked this pull request as ready for review July 31, 2024 09:18
staudtMarius
staudtMarius previously approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@danielfeismann danielfeismann mentioned this pull request Aug 4, 2024
Merged
@danielfeismann danielfeismann mentioned this pull request Aug 8, 2024
Draft
jo-bao
jo-bao approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good merge!

@jo-bao jo-bao merged commit 2268691 into dev Aug 12, 2024
5 checks passed
@danielfeismann danielfeismann deleted the df/#872-merge-hp-testdata branch August 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-bao jo-bao jo-bao approved these changes

@staudtMarius staudtMarius staudtMarius left review comments

Assignees

@danielfeismann danielfeismann

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge HpTestData and HpModelTestData
4 participants
@danielfeismann @jo-bao @staudtMarius @pierrepetersmeier