Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote RefSystemTest from groovy to scala. #839

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Rewrote RefSystemTest from groovy to scala. #839

merged 9 commits into from
Jul 25, 2024

Conversation

pierrepetersmeier
Copy link
Contributor

RefSystemTest convert from groovy to scala.

This PR is related to Issue #646

@pierrepetersmeier pierrepetersmeier linked an issue Jun 28, 2024 that may be closed by this pull request
Convert groovy tests to ScalaTest, remove groovy #646
Open
@pierrepetersmeier pierrepetersmeier added this to the Version 4.0 milestone Jun 28, 2024
@pierrepetersmeier pierrepetersmeier added code quality Code readability or efficiency is improved test Issues related to (unit) tests labels Jun 28, 2024
@pierrepetersmeier pierrepetersmeier self-assigned this Jun 28, 2024
danielfeismann
danielfeismann requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor remarks

src/test/scala/edu/ie3/simona/model/grid/RefSystemSpec.scala Outdated Show resolved Hide resolved
src/test/scala/edu/ie3/simona/model/grid/RefSystemSpec.scala Outdated Show resolved Hide resolved
danielfeismann
danielfeismann requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)

src/test/scala/edu/ie3/simona/model/grid/RefSystemSpec.scala Outdated Show resolved Hide resolved
@pierrepetersmeier
Copy link
Contributor Author

!test

danielfeismann
danielfeismann requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little last thing

src/test/scala/edu/ie3/simona/model/grid/RefSystemSpec.scala Outdated Show resolved Hide resolved
danielfeismann
danielfeismann approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for your work!

@danielfeismann danielfeismann merged commit 20f5c23 into dev Jul 25, 2024
4 checks passed
@danielfeismann danielfeismann deleted the pp/#646-refsystemtest-convert-groovy-test-to-scalatest branch July 25, 2024 08:35
@danielfeismann danielfeismann mentioned this pull request Jul 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@pierrepetersmeier pierrepetersmeier

Labels
code quality Code readability or efficiency is improved test Issues related to (unit) tests
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

Convert groovy tests to ScalaTest, remove groovy
2 participants
@pierrepetersmeier @danielfeismann