Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Java 17 #60

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Upgrading to Java 17 #60

merged 2 commits into from
Jan 10, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #58

I had to adapt PVModelTest, possibly due to changed floating point semantics in JDK17.

@sebastian-peter sebastian-peter added the dependencies Pull requests that update a dependency file label Jan 10, 2022
@sebastian-peter sebastian-peter self-assigned this Jan 10, 2022
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (81.60% Estimated after merge)
  • No duplication informationNo duplication information (0.50% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #60 (a4d56be) into dev (7c6a4d3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #60      +/-   ##
==========================================
- Coverage   79.32%   79.31%   -0.02%     
==========================================
  Files         155      155              
  Lines        5746     5747       +1     
  Branches       80       80              
==========================================
  Hits         4558     4558              
- Misses       1188     1189       +1     
Impacted Files Coverage Δ
...ain/scala/edu/ie3/simona/config/SimonaConfig.scala 60.60% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61605df...a4d56be. Read the comment docs.

@johanneshiry johanneshiry merged commit 3741bf1 into dev Jan 10, 2022
@johanneshiry johanneshiry deleted the sp/#58-java-17 branch January 10, 2022 14:08
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Java 17
2 participants