Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter for thermal result checking for lastTick not for currentTick #1008

Closed
danielfeismann opened this issue Oct 29, 2024 · 0 comments · Fixed by #1009
Closed

Fix filter for thermal result checking for lastTick not for currentTick #1008

danielfeismann opened this issue Oct 29, 2024 · 0 comments · Fixed by #1009
Assignees
@danielfeismann
Labels
bug Something isn't working

Comments

@danielfeismann
Copy link
Member 

          Looks to me that this rather should be lastTick. Since we yet haven't any ThermalGridIT this comes not directly clear.

' .filter { case (_, state) => state.tick == lastTick}'

Originally posted by @danielfeismann in #925 (comment)
@danielfeismann danielfeismann self-assigned this Oct 29, 2024
@danielfeismann danielfeismann added the bug Something isn't working label Oct 29, 2024
@danielfeismann danielfeismann mentioned this issue Oct 29, 2024
Merged
danielfeismann added a commit that referenced this issue Oct 29, 2024
@danielfeismann
Merge branch 'df/#1008-thermalResultsFilter' into df/#878-thermalGridIT
2ed6f02 
# Conflicts:
#	CHANGELOG.md
sebastian-peter added a commit that referenced this issue Nov 1, 2024
@sebastian-peter
Merge pull request #1009 from ie3-institute/df/#1008-thermalResultsFi…
f51a719 
…lter

Fix filter for thermal result checking for lastTick not for currentTick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix filter for thermal result checking for lastTick not for currentTick ie3-institute/simona
1 participant
@danielfeismann