-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region coordinator #104
Region coordinator #104
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #104 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 25 25
Lines 1512 1512
Branches 236 236
=====================================
Misses 1512 1512 Continue to review full report at Codecov.
|
Currently, the test for area calculation is failing, because the area is overestimated by around 60 % as of test case. However, the issues seems to stem from the transformation from angles to metres / distances, as the circumfence of the building is also overestimated by ~ 30 %. I'd guess, that the root lays in the haversine equation or the assumed earth radius or whatever. We have to 🤿 into this. |
With the changes of @t-ober in #175, the area calculation will be done in PowerSystemUtils package. Wait until that PR is closed and see, if the changed logic resolves the issue. |
... as this will be part of PowerSystemUtils package
to restrict load clustering to happen inside land uses or without respecting them
of load locations, if that is needed.
what has to be done next.
According to the new region partitioning scheme proposed in #120, this implementation doesn't make sense anymore. Will provide the logic in another PR. Please do NOT delete the branche. Parts of the code could still be useful. |
Resolves #91