[wip] take better advantage of jsonptr #45
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmello
commented
Oct 18, 2024
| @@ -72,12 +72,11 @@ fn run_patch_test_case(tc: &PatchTestCase, kind: PatchKind) -> Result<Value, Str | |||
| // Patch and verify that in case of error document wasn't changed | |||
| let patch: Patch = serde_json::from_value(tc.patch.clone()).map_err(|err| err.to_string())?; | |||
| json_patch::patch(&mut actual, &patch) | |||
| .map_err(|e| { | |||
There was a problem hiding this comment.
This is an incidental clippy suggestion.
asmello
commented
Oct 19, 2024
| Value::Array(ref mut arr) if allow_last && last_unescaped == "-" => Ok(arr.pop().unwrap()), | ||
| Value::Array(ref mut arr) => { | ||
| let idx = parse_index(last_unescaped, arr.len())?; | ||
| // XXX: is this really correct? semantically it seems off, `-` refers to an empty position, not the last element |
There was a problem hiding this comment.
@idubrov could you share some context here?
asmello
commented
Oct 19, 2024
| @@ -15,7 +15,8 @@ default = ["diff"] | |||
| diff = [] | |||
|
|
|||
| [dependencies] | |||
| jsonptr = "0.6.0" | |||
| # jsonptr = "0.6.0" | |||
| jsonptr = { git = "https://github.com/asmello/jsonptr", branch = "main" } | |||
There was a problem hiding this comment.
Temporary until the upstream PRs get merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonptrhas been upgraded with more specialised utility functions that this crate reimplements. Let's delegate low-level string manipulation to the source crate and take advantage of the nifty new zero-copy APIs.Still work in progress. Blocking on chanced/jsonptr#80 due to a regression in catching an edge case with
+prefixes in array indices.