XDG Base Directory Specification compliance #4844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the usual ~/.idris directory exists, use it for config files and cache. When not, use the ones returned by getXdgDirectories.
Specify the backwards-compatible behaviour on config file searching.
|
I'm not really sure how to fix this issues. I can't really find anything about them on the contribution guide, so I'd appreciate some guidance. |
|
Just noticed there's another PR open for this same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idris currently stores it's configuration files and cache (history file) on the
~/.idrisdirectory. To comply with the XDG Base Directory Specification, it should use$XDG_CONFIG_HOME/idris(~/.config/idrisby default) for configurations and$XDG_CACHE_HOME/idris(~/.cache/idrisby default) for cache data.However, doing that in a backwards compatible manner requries a work-around. With this commits, the REPL would use the old directory, if it exists, for both configuration and cache data, using the XDG ones otherwise (c.f. this comment).