Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax safe bounds, Fixes #3543. #3549

Merged
merged 3 commits into from
Dec 6, 2016
Merged

Relax safe bounds, Fixes #3543. #3549

merged 3 commits into from
Dec 6, 2016

Conversation

jfdm
Copy link
Contributor

@jfdm jfdm commented Dec 5, 2016

Adjusted bounds in cabal file, but not in stack config. That can come later.

Jan de Muijnck-Hughes added 2 commits December 5, 2016 10:00
Adjusted bounds in cabal file, but not in stack config. That can come later.
Print locations of cabal and ghc used for building, in case `PATH` has been misconfigured.
@jfdm jfdm mentioned this pull request Dec 5, 2016
@jfdm
Copy link
Contributor Author

jfdm commented Dec 5, 2016

Right, after digging around I think we are experiencing this cabal issue. Whilst a backdated patch was released for 'older' cabal versions, it appears that the HVR PPA to get ghc versions on Ubuntu didn't push the fixed version of Cabal for 1.20. This is the cabal we are experiencing problems with.

Two ways, forward:

  1. We bump the cabal versions to latest and greatest for all build's. IIRC cabal is backwards compatible. This comes at the cost of realistic assumptions about ghc and cabal version parings, however, we could assume and specify that everyone where they can updates their cabal, and ensure that PATH is setup correctly.

  2. We ask HVR to provide a more up-to-date version of Cabal in their archive.

@juhp
Copy link
Contributor

juhp commented Dec 6, 2016

I am not sure, but would:

if impl(ghc < 7.7)
   Build-depends: safe == 0.3.9

help? Though (2) sounds good too.

safe 0.3.10 is having issues with cabal 1.20 and ghc 7.6.3, the
hvr ghc ppa doesn't provide a new enough cabal library. Temporary
fix until hvr ghc ppa is fixed or we deprecate support for 7.6.3.
@jfdm
Copy link
Contributor Author

jfdm commented Dec 6, 2016

@juhp I've done (2), and didn't think of adding in a conditional to cabal. Although, I am not in favour of such conditionals, I do see their need. I've pushed a fix and hopefully this will work. Thanks for the comments.

@jfdm
Copy link
Contributor Author

jfdm commented Dec 6, 2016

The Mac OS X build timed out during benchmarking. Given that the rest of the test suite passed, and the change resulted in a successful build and test run, I think it is safe to merge.

@jfdm jfdm merged commit 6fc3627 into idris-lang:master Dec 6, 2016
@jfdm jfdm deleted the fix-safe-bounds branch December 6, 2016 11:20
@juhp
Copy link
Contributor

juhp commented Dec 7, 2016

Thanks! Then hopefully the next release will build in Stackage Nightly again. :-)

Only other suggest that came to mind now was requiring newer Cabal to build, but your change looks good/optimal to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants