-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation(documentation-website): Update API bench link on docs w… #965
documentation(documentation-website): Update API bench link on docs w… #965
Conversation
…ebsite Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Please make sure the actions pass. Once your pull request has been merged, you will automatically be added to the contributor's list on the website.
If you want to be shouted out on Linkedin, have a look for the shoutout issue of the specific version.
You can also find us on slack at idrinth-api-bench.
Warning Rate Limit Exceeded@Idrinth has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 5 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughCodeRabbit assimilates the collective shift in namespace from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…ebsite. Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
…n docs website." This reverts commit 55a3790.
…n docs website" This reverts commit 6198640.
…ebsite. Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all changes that are unrelated to the new github url, they don't make sense yet, due to the packages not yet existing
Hi @Idrinth I've already removed changes I made in package json files. Any other files you're pointing? |
Great! May be in readmes for package names as well - it's pretty much ONLY about the github link so far, since everything else needs to be published under the new name first |
@@ -118,7 +118,7 @@ npm run coai | |||
<Lang lnkey={'contributing.code.setup.description'}/> | |||
</p> | |||
<Code language='bash'>{` | |||
git clone https://github.com/idrinth/api-bench | |||
git clone https://github.com/idrinth-api-bench/api-bench |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can keep this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Hi @arnabnandy7 you should only keep changes related to the new github repo url, the npm package is still https://www.npmjs.com/package/@idrinth/api-bench it's not changed yet. So no need to change the stuff in the localization files or the website's header yet :) I left you some comments of what you can keep. |
That's great @marikadeveloper thanks for your support. I'll make the changes. |
Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- documentation-website/language/it.yml (1 hunks)
- documentation-website/src/components/header.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- documentation-website/language/it.yml
- documentation-website/src/components/header.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- documentation-website/src/components/header.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- documentation-website/src/components/header.tsx
@Idrinth @marikadeveloper it's done, please review once |
Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- documentation-website/cypress/e2e/autowiring.cy.ts (1 hunks)
- documentation-website/cypress/e2e/contributors.cy.ts (1 hunks)
- documentation-website/cypress/e2e/middlewares.cy.ts (1 hunks)
- documentation-website/cypress/e2e/sponsors.cy.ts (1 hunks)
- documentation-website/src/components/header.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- documentation-website/cypress/e2e/autowiring.cy.ts
- documentation-website/cypress/e2e/contributors.cy.ts
- documentation-website/cypress/e2e/sponsors.cy.ts
- documentation-website/src/components/header.tsx
Additional Context Used
GitHub Check Runs (1)
lint failure (2)
documentation-website/cypress/e2e/middlewares.cy.ts: [warning] 14-14:
Trailing spaces not allowed
Path-based Instructions (1)
documentation-website/cypress/e2e/middlewares.cy.ts (1)
Pattern
**/*.ts
: Review the code for conformity with the .eslintrc files in / and /*/.
cy.title().should('eq', 'Middlewares | Usage | ' + | ||
'@idrinth/api-bench',); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces detected. CodeRabbit recommends removal for cleaner code.
- cy.title().should('eq', 'Middlewares | Usage | ' +
+ cy.title().should('eq', 'Middlewares | Usage | ' +
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
cy.title().should('eq', 'Middlewares | Usage | ' + | |
'@idrinth/api-bench',); | |
cy.title().should('eq', 'Middlewares | Usage | ' + | |
'@idrinth/api-bench',); |
Refs Issue idrinth-api-bench#958 - This commit updates the API bench link on the documentation website to reflect the changes made in Issue idrinth-api-bench#958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- documentation-website/cypress/e2e/middlewares.cy.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- documentation-website/cypress/e2e/middlewares.cy.ts
@Idrinth it's done, please let me know if more to be done. |
Quality Gate passedIssues Measures |
The Pull Request is ready
Overview
Review points
Documentation-Website
Notes