-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation(documentation-website): german #827
Conversation
Bis zeile 18 Übersetzt
Leerzeichen hinzugefügt
Bis Zeile 57 übersetzt
Changed til line 93
107
WalkthroughThe assimilated changes involve the introduction of a new file, Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Please make sure the actions pass. Once your pull request has been merged, you will automatically be added to the contributor's list on the website.
If you want to be shouted out on Linkedin, have a look for the shoutout issue of the specific version.
You can also find us on slack at idrinth-api-bench.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BrinaBre - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
description: "Willkommen in der Dokumentation für das Framework @idrinth/api-bench" | ||
title: "Was macht das Projekt?" | ||
what: "Dieses Pojekt bietet ein Framework zur Überprüfung von REST-APIs und Websites auf Änderungen der Antwortzeilen" | ||
why:"Dies hilft dabei, Leistungsänderungen im Code schnell und einfach zu erkennen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pojekt
should be corrected to Projekt
.
- Dieses Pojekt bietet ein Framework zur Überprüfung von REST-APIs und Websites auf Änderungen der Antwortzeilen
+ Dieses Projekt bietet ein Framework zur Überprüfung von REST-APIs und Websites auf Änderungen der Antwortzeilen
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
why:"Dies hilft dabei, Leistungsänderungen im Code schnell und einfach zu erkennen" | |
why:"Dies hilft dabei, Leistungsänderungen im Code schnell und einfach zu erkennen" |
what: "Dieses Pojekt bietet ein Framework zur Überprüfung von REST-APIs und Websites auf Änderungen der Antwortzeilen" | ||
why:"Dies hilft dabei, Leistungsänderungen im Code schnell und einfach zu erkennen" | ||
benchmark: | ||
title: "Warum einen benschmakr-Runner verwenden?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
benschmakr
should be corrected to Benchmark
.
- Warum einen benschmakr-Runner verwenden?
+ Warum einen Benchmark-Runner verwenden?
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
title: "Warum einen benschmakr-Runner verwenden?" | |
title: "Warum einen Benchmark-Runner verwenden?" |
title_2: "Was ist ein Lassttest?" | ||
description_2: "Lasttests bewerten das Verhalten eines Systems unter Spitzen- oder erwarteten Lastbedingungen." | ||
title_3: "Wie lange dauert es einen Test zu schreiben?" | ||
description_3: " Die durschnittliche Zeit beträgt 2-3 Minuten.Es kann aber bis zu 15 Minuten dauern. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
durschnittliche
should be corrected to durchschnittliche
.
- Die durschnittliche Zeit beträgt 2-3 Minuten.Es kann aber bis zu 15 Minuten dauern.
+ Die durchschnittliche Zeit beträgt 2-3 Minuten. Es kann aber bis zu 15 Minuten dauern.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
description_3: " Die durschnittliche Zeit beträgt 2-3 Minuten.Es kann aber bis zu 15 Minuten dauern. " | |
description_3: " Die durchschnittliche Zeit beträgt 2-3 Minuten. Es kann aber bis zu 15 Minuten dauern. " |
title_6: "Gibt es zusätzliches Unterrichtsmaterial?" | ||
description_6: "Noch nicht, es wird aktiv daran gearbeitet." | ||
title_7: "Ist die Nutzung des Frameworks kostenlos?" | ||
description_7: "Yes, entirely. Even support via GitHub is free." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation inconsistency: Yes, entirely.
should be translated to German.
- Yes, entirely.
+ Ja, vollständig.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
description_7: "Yes, entirely. Even support via GitHub is free." | |
description_7: "Ja, vollständig. Even support via GitHub is free." |
description_7: "Yes, entirely. Even support via GitHub is free." | ||
title_8: "How fast is the public support?" | ||
description_8: "We strive to react within 24h and latest within 48h." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How fast is the public support?
should be translated to German.
- How fast is the public support?
+ Wie schnell ist der öffentliche Support?
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
description_7: "Yes, entirely. Even support via GitHub is free." | |
title_8: "How fast is the public support?" | |
description_8: "We strive to react within 24h and latest within 48h." | |
description_7: "Yes, entirely. Even support via GitHub is free." | |
title_8: "Wie schnell ist der öffentliche Support?" | |
description_8: "We strive to react within 24h and latest within 48h." |
iab: | ||
description: "This command is going to replace all other commands with a more sensible interface in 3.0.0 and is available from 2.8.0" | ||
arg_1: "'iab bench --language=en --taskId=test --threads=11 --repetitions=100' runs a benchmark with all options being optional." | ||
arg_2: "'iab content --language=en --taskId=test' runs a content tesst/integration test with all options being optional." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical error: tesst
should be corrected to test
.
- 'iab content --language=en --taskId=test' runs a content tesst/integration test with all options being optional.
+ 'iab content --language=en --taskId=test' runs a content test/integration test with all options being optional.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
arg_2: "'iab content --language=en --taskId=test' runs a content tesst/integration test with all options being optional." | |
arg_2: "'iab content --language=en --taskId=test' runs a content test/integration test with all options being optional." |
Quality Gate passedIssues Measures |
will be fixing and merging this later - please feel free to continue the translation in the proper new repo then :) @BrinaBre |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- documentation-website/language/de.yml (1 hunks)
Additional comments not posted (3)
documentation-website/language/de.yml (3)
68-68
:Pojekt
should be corrected toProjekt
.
71-71
:benschmakr
should be corrected toBenchmark
.
100-100
:durschnittliche
should be corrected todurchschnittliche
.
German translation for documentation website
fixes #194