Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 331 corrected #498

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

aceppaluni
Copy link
Member

@aceppaluni aceppaluni commented Mar 25, 2024

The Pull Request is ready

  • fixes #
  • all actions are passing
  • only fixes a single issue

Overview

Review points

Documentation-Website

  • mobile view is usable
  • desktop view is usable
  • no a-tags are used directly (NavLink, MailLink, ExternalLink instead)
  • all new texts are added to the translation files (at least the english one)
  • tests have been added (if required)
  • shared code has been extracted in a different file

Notes

@Idrinth Idrinth marked this pull request as ready for review March 25, 2024 19:34
documentation-website/src/pages/usage/routes/index.tsx Outdated Show resolved Hide resolved
documentation-website/language/en.yml Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

@Idrinth Idrinth merged commit b1b34d1 into idrinth-api-bench:master Mar 26, 2024
23 of 24 checks passed
@aceppaluni aceppaluni deleted the angies-contribution branch March 26, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants