New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(documentation-website):add contributor name as id #480

Merged

Idrinth merged 1 commit into idrinth-api-bench:master from stephviz:issue-255-contributor-listing

Mar 24, 2024

Contributor

stephviz commented Mar 24, 2024 •

edited

Loading

The Pull Request is ready

fixes Add ids to contributor listing, so you can link to a specific one #255
all actions are passing
only fixes a single issue

Overview

add contributor name as id

Documentation-Website

mobile view is usable
desktop view is usable
no a-tags are used directly (NavLink, MailLink, ExternalLink instead)
all new texts are added to the translation files (at least the english one)
tests have been added (if required)
shared code has been extracted in a different file


          feature(documentation-website):add contributor name as id

0db18b9

sonarqubecloud bot commented Mar 24, 2024

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

Contributor Author

stephviz commented Mar 24, 2024

Coveralls test coverage went down. Please advise on how to pass this 🙏

Idrinth merged commit e5b1977 into idrinth-api-bench:master

23 of 24 checks passed

Member

Idrinth commented Mar 24, 2024

Coveralls test coverage went down. Please advise on how to pass this 🙏

looks like a random rounding issue tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet