Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Header Responsive #342

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

AnukratiMehta
Copy link
Contributor

@AnukratiMehta AnukratiMehta commented Feb 21, 2024

The Pull Request is ready

Website

  • mobile view is useable
  • desktop view is useable
  • no a-tags are used direktly (NavLink, MailLink, ExternalLink instead)
  • all new texts are added to the translation files (at least the english one)
  • tests have been added (if required)
  • shared code has been extracted in a different file

Additional Notes

@Idrinth please note that the UI is breaking due to footer responsiveness issues as well. Kindly create a separate issue for the same and assign it to me. Thanks!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!
Please make sure the actions pass. Once your pull request has been merged, you will automatically be added to the contributor's list on the website.
If you want to be shouted out on Linkedin, have a look for the shoutout issue of the specific version.

@@ -289,7 +289,7 @@ nav.breadcrumbs li:last-of-type::after {
margin-right: 4rem;
}

header,
header,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the added trailing space :)

@@ -430,3 +430,14 @@ nav.breadcrumbs li:last-of-type::after {
background-color: var(--black);
}
}

@media screen and (width <= 900px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will apply to all mobile views as well, is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, my bad. Fixing it in the next commit.

@Idrinth
Copy link
Member

Idrinth commented Feb 21, 2024

@Idrinth please note that the UI is breaking due to footer responsiveness issues as well. Kindly create a separate issue for the same and assign it to me. Thanks!

A big thank you to you! Will create it right away, but need a comment from you in there, so that I can assign it to you.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Idrinth Idrinth merged commit da1d76a into idrinth-api-bench:master Feb 21, 2024
5 checks passed
@AnukratiMehta AnukratiMehta deleted the header-responsive branch February 21, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header navigation is wider than the screen at ~tablet size
2 participants