-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Header Responsive #342
Make Header Responsive #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Please make sure the actions pass. Once your pull request has been merged, you will automatically be added to the contributor's list on the website.
If you want to be shouted out on Linkedin, have a look for the shoutout issue of the specific version.
website/src/index.css
Outdated
@@ -289,7 +289,7 @@ nav.breadcrumbs li:last-of-type::after { | |||
margin-right: 4rem; | |||
} | |||
|
|||
header, | |||
header, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the added trailing space :)
website/src/index.css
Outdated
@@ -430,3 +430,14 @@ nav.breadcrumbs li:last-of-type::after { | |||
background-color: var(--black); | |||
} | |||
} | |||
|
|||
@media screen and (width <= 900px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will apply to all mobile views as well, is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, my bad. Fixing it in the next commit.
A big thank you to you! Will create it right away, but need a comment from you in there, so that I can assign it to you. |
Quality Gate passedIssues Measures |
The Pull Request is ready
Website
Additional Notes
@Idrinth please note that the UI is breaking due to footer responsiveness issues as well. Kindly create a separate issue for the same and assign it to me. Thanks!