Skip to content

Commit

Permalink
implement issue #951 (#966)
Browse files Browse the repository at this point in the history
* fix (external-link) : revert name to pascal case

* feat (header) : add feedback line in navbar (#951)

* Update header.tsx

* Update external-link.tsx

* Update header.tsx

---------

Co-authored-by: Björn Büttner <[email protected]>
  • Loading branch information
matin-mortazavi and Idrinth authored May 6, 2024
1 parent ba8acd4 commit 0f7be30
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
12 changes: 9 additions & 3 deletions documentation-website/src/components/external-link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,16 @@ import React from 'react';
import {
FiExternalLink,
} from 'react-icons/fi';
const externalLink = ({

interface ExternalLinkType {
to: string;
label?: string;
}

const ExternalLink = ({
to,
label = '',
},) => <a
}: ExternalLinkType,) => <a
className="external-link"
href={to}
target='_blank'
Expand All @@ -15,4 +21,4 @@ const externalLink = ({
<FiExternalLink className="external-link-icon"/>
</a>;

export default externalLink;
export default ExternalLink;
4 changes: 4 additions & 0 deletions documentation-website/src/components/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import DarkModeButton from './dark-mode-button.tsx';
import './header.scss';
import Lang from './lang.tsx';
import SocialLink from './social-link.tsx';
import ExternalLink from './external-link.tsx';

const preventOpenLink = (event: React.MouseEvent<SVGElement, MouseEvent>,) => {
event.preventDefault();
Expand Down Expand Up @@ -100,6 +101,9 @@ const Header = ({
</nav>
<nav aria-label='Main Menu'>
<ul>
<li>
<ExternalLink to="https://tally.so/r/3NA48l" label='Feedback'/>
</li>
<li>
<NavLink to="/quick-start/">
<Lang lnkey='nav.quick-start'/>
Expand Down

0 comments on commit 0f7be30

Please sign in to comment.