Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IGNORE_ADMIN_APP to settings #185

Closed
wants to merge 1 commit into from
Closed

Conversation

ar4s
Copy link

@ar4s ar4s commented Dec 7, 2015

I customized admin panel and I replaced standard django menu system by sitetree and I need this change for correctly display menu items when user have limited permissions.

@idlesign
Copy link
Owner

idlesign commented Dec 7, 2015

Do you mean that you need to restrict tree items access for admin users?
If so, how do you plan to differentiate calls to render admin nav and to render tree editor items (some tree items could be anavailable in this case)?

@ar4s
Copy link
Author

ar4s commented Dec 9, 2015

In my case admin panel is base tool for all users, but have different permission and use sitetree only for show menu - menu editor is irrelevant in this case.

@idlesign
Copy link
Owner

idlesign commented Dec 9, 2015

I see. It seems that we need something similar to SITETREE_ADMIN_APP_NAME setting to cover more use cases (e.g. admin app overriden). So that at https://github.com/idlesign/django-sitetree/blob/master/sitetree/sitetreeapp.py#L417 we check against SITETREE_ADMIN_APP_NAME.
For your use case any name will do.

@idlesign
Copy link
Owner

Partially implemented in ecdbc7f.
Considered closed.
Feel free to reopen if required.

@idlesign idlesign closed this Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants