Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new type of instances #11

Open
mogol07 opened this issue Aug 30, 2024 · 2 comments · May be fixed by #15
Open

Support new type of instances #11

mogol07 opened this issue Aug 30, 2024 · 2 comments · May be fixed by #15

Comments

@mogol07
Copy link

mogol07 commented Aug 30, 2024

Hi!
According news from 06.06.24 https://docs.hetzner.cloud/whats-new#2024-06 Hetzner deprecated tariffs cxN1(cx11...cx51). Since 06.09.24 (in one week from now) it would be unavailable from API.

Right now, it's not possible to use it due two problem:

  1. Validation checked with regex
    can(regex("^(cp?x[1-5]1|cax[1-4]1|ccx[1-6]3)$", var.node_type)),
    but it could be easily fixed by
    can(regex("^(cp?x[1-5][1-2]|cax[1-4]1|ccx[1-6]3)$", var.node_type))
  2. But the second problem is more complicated. Network interface name is changed from ens10 to enp7s0. Because other type of instances use older name, it's required lookup variable, and I don't know how to organize it better, beside basic list.
  3. BTW, internet gateway has hardcoded type of instance as cx11, it's also need to update, and maybe better to let user to configure it in main.tf?

I also has some other problem, but I am not sure about the reason of it (maybe new Ubuntu 24.04, so I need to test more, before create next ticket ;) )

@mogol07
Copy link
Author

mogol07 commented Sep 2, 2024

If replaced hardcoded ens10 to enp7s0, and used only cxN2 instances, then cluster is working on ubuntu 22.04.

@jceb
Copy link
Member

jceb commented Sep 4, 2024

Yes, the changing instance types are a bit of a challenge. Please submit a PR that updates the regex.

Please also submit a PR for making the gateway type configurable.

Ideally, we'd somehow detect the correct network interface dynamically. Do you want to give it a try?

mogol07 added a commit to mogol07/terraform-hcloud-k3s that referenced this issue Sep 5, 2024
@mogol07 mogol07 linked a pull request Sep 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants