-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from js-sha3 to audited noble-hashes #416
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebuilt the CLI and it seems that we are blocked here by the use of node:
imports until we upgrade the minimum version of nodejs we support.
I'll try harder to push that forward!
But you don't even support v12 fully? snarkjs/.github/workflows/tests.yml Line 14 in 918b4ad
snarkjs/.github/workflows/tests.yml Line 42 in 918b4ad
In my opinion, supporting anything less than v18 is dangerous, because there are no security updates for these, and this is security-sensitive project. It's common now to use something else than node, such as bun / deno, so it's best to support bun instead of ancient node. |
The minimum supported version isn't up to me 😂 like I said, I'll continue to press. |
Closes gh-310
https://github.com/paulmillr/noble-hashes#security