Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix chainid for polygon zkevm cardona #465

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix chainid for polygon zkevm cardona #465

merged 1 commit into from
Sep 16, 2024

Conversation

daveroga
Copy link
Contributor

Fix chainId for polygon zkEVM cardona that is now with 1442 like the old zkEVM testnet and should be 2442.

@volodymyr-basiuk
Copy link
Contributor

volodymyr-basiuk commented Sep 16, 2024 •
edited
Loading

Should we change blockchainNetworkMap here as well ?
{Blockchain: ZkEVM, NetworkID: Main}: this is incorrect as I understand

@vmidyllic
Copy link
Contributor

Should we change blockchainNetworkMap here as well ? {Blockchain: ZkEVM, NetworkID: Main}: this is incorrect as I understand

we already removed zkemv as blockchain

@vmidyllic vmidyllic merged commit 9c64d6a into master Sep 16, 2024
6 checks passed
@vmidyllic vmidyllic deleted the fix/cardona-chainid branch September 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmidyllic vmidyllic vmidyllic approved these changes

@volodymyr-basiuk volodymyr-basiuk volodymyr-basiuk approved these changes

@OBrezhniev OBrezhniev OBrezhniev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daveroga @volodymyr-basiuk @vmidyllic @OBrezhniev