Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds check non-strict Num2Bits and Bits2Nums #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ecnerwala
Copy link

Num2Bits is not well defined with n > 253 and could lead to aliasing; disallow these sizes, as they are almost always mistakes. Users who intend to explicitly handle aliasing can write their own circuit.

If the highest bit is required, Num2Bits_strict performs a 254-bit decomposition and includes an alias check.

ecnerwala and others added 3 commits March 29, 2022 13:14
Num2Bits is not well defined with n > 253 and could lead to aliasing; disallow these sizes, as they are almost always mistakes. Users who intend to explicitly handle aliasing can write their own circuit.

If the highest bit is required, Num2Bits_strict performs a 254-bit decomposition and includes an alias check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant