Bounds check non-strict Num2Bits and Bits2Nums #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Num2Bits is not well defined with n > 253 and could lead to aliasing; disallow these sizes, as they are almost always mistakes. Users who intend to explicitly handle aliasing can write their own circuit.
If the highest bit is required, Num2Bits_strict performs a 254-bit decomposition and includes an alias check.