Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Fix FunctionCallTag registering in iOS and support to manually refreshing the container #316

Merged
merged 13 commits into from
Mar 15, 2019
Merged

Fix FunctionCallTag registering in iOS and support to manually refreshing the container #316

merged 13 commits into from
Mar 15, 2019

Commits on Jun 17, 2018

  1. Load default container if available in Android. 

    Support Function Call tags in both environments.
    @fshafiee
    fshafiee committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    e8c98dd View commit details
    Browse the repository at this point in the history

  2. Fix typos in comments of RNFunctionCallTagHandler.h

    @fshafiee
    fshafiee authored Jun 17, 2018
    Configuration menu
    Copy the full SHA
    3509673 View commit details
    Browse the repository at this point in the history

  3. Remove extra comments in RNFunctionCallTagHandler.m

    @fshafiee
    fshafiee authored Jun 17, 2018
    Configuration menu
    Copy the full SHA
    35329ce View commit details
    Browse the repository at this point in the history

  4. Update comments in RNTagEmitterSingleton.m

    @fshafiee
    fshafiee authored Jun 17, 2018
    Configuration menu
    Copy the full SHA
    079c1f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2018

  1. Delete event emitter singleton module from iOS native modules and use… 

    … RCTGoogleTagManagerBridge itself as the emitter

Fix missing function name not being provided to registered function call tag handler in iOS
Rename JS helper module to FunctionCallTagHandler to better conform to actual GTM namings.
    @fshafiee
    fshafiee committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    06e399f View commit details
    Browse the repository at this point in the history

  2. Refactor helper Wrirtable data structure converter methods into Conve… 

    …rtToWritable class
    @fshafiee
    fshafiee committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    8b5958c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2018

  1. Pulled updates from main repo

    @fshafiee
    fshafiee committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    bd3a43f View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2018

  1. Fix registerFunctionCallTagHandler method where it emit method was ca… 

    …lled on an undefined object.

It is now possible to manually request the container to be refreshed.
    @fshafiee
    fshafiee committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    1113f3a View commit details
    Browse the repository at this point in the history

  2. Update RCTGoogleTagManagerBridge.m

    @fshafiee
    fshafiee authored Nov 11, 2018
    Configuration menu
    Copy the full SHA
    6b697e3 View commit details
    Browse the repository at this point in the history

  3. Update RCTGoogleTagManagerBridge.m

    @fshafiee
    fshafiee authored Nov 11, 2018
    Configuration menu
    Copy the full SHA
    cd21082 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Merge remote-tracking branch 'upstream/master'

    @fshafiee
    fshafiee committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    e53c0a7 View commit details
    Browse the repository at this point in the history

  2. Revert iOS container openType back to kTAGOpenTypePreferFresh

    @fshafiee
    fshafiee committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    0ab61e1 View commit details
    Browse the repository at this point in the history

  3. Ignore package-lock.json

    @fshafiee
    fshafiee committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    8b24ec9 View commit details
    Browse the repository at this point in the history