Untitled #149
Untitled #149
Conversation
… optional passwords
- Debug switch - ModalPresentationStyle (for iPad apps) - ModalTransitionStyle (for iPad apps) New Features: - Logout of all services +[SHK logoutOfAll] - Logout of specific service +[SHK logoutOfService:serviceId] Critical Fixes: - Delicious token expiring after 1 hour - Bit.ly could return non-bit.ly domains causing shortened url to be rejected Minor Improvements: - SHKActionSheet tried to act on indexes less than 0 - Cancelling OAuth login no longer prompts 'user cancelled' error message Other bug fixes
- Fixed facebook logout - Added additional comments for setting up twitter - Added sanity check to catch pin based auth with twitter - Version 0.1.6 - release going to website
You can add your own language by simply adding your lang in ShareKit.bundle. You have to include ShareKit.bundle now in your project
…t were evaluated on clickedButtonAtIndex. This produced a black screen when no mail client was setup, mail was a favorite and the user pressed "more".
- SHKPhotoAlbum: Save images to photo album action - Facebook accepts text sharing Fixes: - SHKItem now carries over full item when sharing - Crash when saving items offline that did not contain custom variables - Modal popups would not go away when using pagesheet modal type on iPad - Editing sharers now affects actionsheet choices - Race condition in SHKShareMenu Improvements: - Improved display of SHKTwitterForm on iPad - Facebook uses text variable when sharing urls to repopulate status message - SHKMail now uses up to date template, improved handling of text when it's available in SHKItem - Updated SHKActionSheet to not override delegate, now you can assign your own delegate Code Refactoring: - Renamed SHLocalizedString to use proper SHK prefix - Updated SHKLocalizedString to work like stringWithFormat - Removed/Combined some localization strings
-SHKTwitter: Don't attempt to shorten while offline -SHKTwitter: Crash on @"Follow %@" format string -SHKEmail: Added 'Sent with ...' -SHKDelicious: Titles were double encoded -SHK: SHKStringOrBlank function -Updated FBConnect to version 1.3.0
…set to NO for AutoShare
…io from 0.0 to 1.0
…oauth authentication failure
…preciated constant.
…p, but instead shows an alert when selected.
… to 2 seconds to improve readability.
…MBProgressHUD, now included in the project via a git submodule.
…s/ShareKit commit 4485026).
…pport at the moment.
…ring options is the same as the total number of options.
|
There's some good stuff in here, but you should review it for security. I noticed right off the bat that twitter usernames/passwords are stored in NSUserDefaults, which could compromise the user's login credentials. |
|
Good catch. Thanks for the heads up. Will review ASAP. |
|
Where did you see this? I'm not finding it. |
|
You know, I may have been taken aback by the simulator-only methods in ShareKit, and thought these applied to the device. |
|
Yeah, I double-checked and that's all it was. Sorry for the false alarm. I do have a verified issue with MBProgressHUD not getting the proper frame, though. I sometimes find it crammed in the bottom left corner on my app which runs in landscape. Rotating the device resets its frame and causes it do display properly in the center. I can't find the right way to fix it, but I have seen it getting negative values for its x coords by placing an NSLog(@"layout x %f", indFrame.origin.x) around line 508 (end of the layoutSubviews method). |
|
Found a fix. You may want to incorporate this: https://github.com/chiefy/MBProgressHUD/commit/d4fab41c429ad9333a022f3dee9609a3ba43ed57#diff-14 |
|
Great! Thanks for letting me know. I haven't seen this issue but will check it out. |
Hi there,
My fork fixes a memory leak in the OAuth helper classes, a crash when clicking the "more" button, and improves the messaging with the MBProgessHUD (and some convenience class methods in SHK.m).
It also has a bunch of other small improvements that I added for my own use and which might be useful in the main branch.