Release 7.0.3 #163
Closed
Release 7.0.3 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix/153 2
Hotfix/153 2
antonioarenzanapulido
requested review from
frantsao,
vicsufer,
blalop,
dortegau,
emepege,
jmonterrubio,
jperera,
marcelogalmor,
sorobon,
ultraheroe and
xtianae7
and removed request for
frantsao
vicsufer
reviewed
Dec 16, 2021
| name: "jdk" | ||
| hostname: "jdk" | ||
| image: "idealista/jdk:{{ docker_tag }}" | ||
| privileged: true |
There was a problem hiding this comment.
I didn't realize before, but we shouldn't use privileged: true
vicsufer
reviewed
Dec 17, 2021
| docker_image: | ||
| name: "idealista/jdk:{{ docker_tag }}" | ||
| source: build | ||
| build: |
There was a problem hiding this comment.
I believe we also want to build the images for arm64, so we0ll need to specify the "platform" parameter in here.
ansible-collections/community.docker#54
Yo may need to iterate the values "linux" and "arm64" to generate the image for different platforms.
vicsufer
reviewed
Dec 17, 2021
| docker_image: | ||
| name: "idealista/jdk:{{ docker_tag }}" | ||
| source: build | ||
| build: |
There was a problem hiding this comment.
I believe we also want to build the images for arm64, so we0ll need to specify the "platform" parameter in here.
ansible-collections/community.docker#54
Yo may need the complete playbook to iterate the values "linux" and "arm64" to generate the image for different platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Packer as uploader of images has been removed for a playbook to take charge of that.
The playbook creates an image, raises a container executes the role on that container and then if everything is okey pushes the image to DockerHub
Benefits
Possible Drawbacks
Applicable Issues
#160