Update for Chrome print to PDF. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the template to help print to PDF on chrome (see gnab/remark#50).
Comparison:
As another thing, is there a way/ do you mind if a config var is added to set a custom template?
Added this as a PR since it helps everyone/doesn't change the look of the presentations at all, but for more opinionated stuff it makes more sense to point to a custom config.
EDIT: I've done a branch in my fork for a custom config, and for dynamically setting the title based on the first
# XXXappearance, so the tab title when you open the presentation is correct.