Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submodule update, refs #0 #452

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Submodule update, refs #0 #452

merged 5 commits into from
Nov 13, 2024

Conversation

GiudGiud
Copy link
Collaborator

@GiudGiud GiudGiud commented Nov 4, 2024

No description provided.

@GiudGiud GiudGiud self-assigned this Nov 4, 2024
@moosebuild
Copy link

moosebuild commented Nov 4, 2024 •
edited
Loading

Job VTB Documentation, step Sync Docs on ac1aa66 wanted to post the following:

View the site here

This comment will be updated on new commits.

@travismui
Copy link
Collaborator

@GiudGiud FYI there were some changes to SAM PKE/DNP, I'll work on a patch for the affected models.

@GiudGiud GiudGiud mentioned this pull request Nov 8, 2024
Merged
GiudGiud and others added 5 commits November 12, 2024 12:35
@GiudGiud
Submodule update, refs #0
886a87f
@pbehne @GiudGiud
Updated deprecated input, re-golded
3a84438 
Changed HeatStructureMaterials block to SolidProperties block, turned off the
use of deprecated volume junction scalar variables, changed parameter name
‘function’ to ‘expression’ in ParsedPostprocessors. Updated other parts of
input to be compatible with these changes. The updated input had the same
results in the csv file as the old version, with some additional columns.
A re-gold was performed to reflect this change.
@pbehne @GiudGiud
Removed deprecated execute_on parameter from ParsedFunction function …
f8a38c8 
…definitions.
@pbehne @GiudGiud
Updated references to deprecated objects.
c7ba333
@GiudGiud
Comment out parameters which were not properly implemented in the Act…
ac1aa66 
…ion-Material interaction for pebble bed depletion
@GiudGiud GiudGiud force-pushed the submodule_update_24_11_04 branch from 5f587e2 to ac1aa66 Compare November 12, 2024 19:35
@GiudGiud
Copy link
Collaborator Author

I removed the SAM submodule update, we can do it separately.
Created #472 for the new gFHR test failure

@GiudGiud GiudGiud merged commit 0870c7a into idaholab:devel Nov 13, 2024
13 checks passed
@GiudGiud GiudGiud deleted the submodule_update_24_11_04 branch November 13, 2024 02:29
@GiudGiud
Copy link
Collaborator Author

GiudGiud commented Dec 4, 2024

@travismui any update on updating the SAM models? We are seeing very many affected in our latest try

@GiudGiud
Copy link
Collaborator Author

GiudGiud commented Dec 4, 2024

There's quite a few warnings that are allowed in SAM and error in BC in the list of failures. I should be able to address those.

@travismui
Copy link
Collaborator

travismui commented Dec 4, 2024 •
edited
Loading

@GiudGiud Apologies this got delayed, I'll get apps/SAM and failing tests updated in VTB today. I'm only seeing failures in two tests (the same that were identified here last time). Are the other numerous(?) failures you're referring to on the BC-side submodule update?

@GiudGiud
Copy link
Collaborator Author

GiudGiud commented Dec 4, 2024

exactly. It s on BC submodule update which include a new SAM. We have a solution for those though so we ll take care of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GiudGiud GiudGiud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GiudGiud @moosebuild @travismui @pbehne