-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alfoa/generic codeinterface fix #844
Merged
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1996c8e
dai
alfoa 8925566
Merge brant checkout workshop_:wq
alfoa 13bcea1
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 95b615e
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 6c6661d
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 7f21d87
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 2c71fc3
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 393ac20
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa afb259b
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 2f8f657
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 7087437
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa 493fa02
oky
alfoa c7130e1
Merge branch 'devel' of https://github.com/idaholab/raven into devel
alfoa b990006
fix generic code interface (parsing)
alfoa 5ffb6ca
ok
alfoa b838818
removed trailingspaces
alfoa 5c86d1b
Update test_BasicStatistics.xml
alfoa 35e806c
addrressed comments
alfoa 66ae608
Merge branch 'alfoa/genericCodeinterfaceFix' of https://github.com/id…
alfoa fe72486
fixed test
alfoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -203,12 +203,13 @@ def submit(self,myInput,samplerType,jobHandler,**kwargs): | |
a mandatory key is the sampledVars'that contains a dictionary {'name variable':value} | ||
@ Out, None | ||
""" | ||
|
||
kwargs['forceThreads'] = True | ||
Model.submit(self,myInput, samplerType, jobHandler,**kwargs) | ||
## This may look a little weird, but due to how the parallel python library | ||
## works, we are unable to pass a member function as a job because the | ||
## pp library loses track of what self is, so instead we call it from the | ||
## class and pass self in as the first parameter | ||
jobHandler.addJob((self, myInput, samplerType, kwargs), self.__class__.evaluateSample, str(0), modulesToImport=self.mods, forceUseThreads=True) | ||
#jobHandler.addJob((self, myInput, samplerType, kwargs), self.__class__.evaluateSample, str(0), modulesToImport=self.mods, forceUseThreads=True) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, justification for keeping commented code. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed |
||
|
||
def evaluateSample(self, myInput, samplerType, kwargs): | ||
""" | ||
|
5 changes: 5 additions & 0 deletions
5
tests/framework/CodeInterfaceTests/GenericInterface/inp.three
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" ?> | ||
<properties> | ||
<x>10</x> | ||
<z>1</z> | ||
</properties> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment explaining why we are saving this material, and on what conditions it can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed