Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the stochastic collocation with gamma distribution #713

Merged
merged 6 commits into from
Aug 3, 2018

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Jul 27, 2018


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #693

What are the significant changes in functionality due to this change request?

bug fix for #693


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@wangcj05 wangcj05 requested a review from PaulTalbot-INL July 27, 2018 20:18
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new gamma test analytic? Can we at least provide some guidance for the correct answers in case regolding is needed someday?

<description>
This tests using SparseGridCollocation with gamma-distributed inputs with large scale parameters
to test the fix for issue #693
</description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test not analytic?

@wangcj05
Copy link
Collaborator Author

@PaulTalbot-INL I created an analytic test for this PR.

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Jul 30, 2018

Did you add the <analytic> node to the corresponding test? I didn't see it in the commit. Found it.

@PaulTalbot-INL
Copy link
Collaborator

This is ready to merge except for the drafted email to the user group.

@alfoa
Copy link
Collaborator

alfoa commented Aug 3, 2018

Checklist passed...

@wangcj05 Please email the users...

Merging...

@alfoa alfoa merged commit a6d2629 into idaholab:devel Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gPC ROM generated using SparseGridCollocation with Gamma distribution is not working correctly
3 participants