Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The connection check for the ensemble model #698

Merged
merged 4 commits into from
Jul 20, 2018
Merged

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Jul 19, 2018


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Resolve issue #696
Fix the defect in the graphObject connected net check
Fix the debug message in OutStreamPrint
Issue #696 can be Closed when branch mandd/CRAFT merged into devel.

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@wangcj05 wangcj05 requested review from alfoa and mandd July 19, 2018 20:13
@wangcj05
Copy link
Collaborator Author

@mandd This PR is for branch mandd/CRAFT. I have a fix for the ensemble model graph connection check. @alfoa You may take a look at the fix.

@wangcj05 wangcj05 changed the title Fix connected check The connection check for the ensemble model Jul 19, 2018
@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code. OK
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts). N/A
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details. OK
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass. OK
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True. N/A
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync. N/A
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done. OK
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added? N/A

@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018

Checklist passed... merging...

@alfoa alfoa merged commit c447dbc into mandd/CRAFT Jul 20, 2018
@alfoa alfoa deleted the fixConnectedCheck branch July 20, 2018 12:16
@wangcj05 wangcj05 restored the fixConnectedCheck branch August 4, 2018 18:39
@alfoa alfoa deleted the fixConnectedCheck branch September 26, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants