Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix optimizer writeStep final (if optimization ends for reaching the limit number of iterations) #2387

Closed
wants to merge 14 commits into from
Closed

fix optimizer writeStep final (if optimization ends for reaching the limit number of iterations) #2387

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d2f4ec3
Closes #2386
alfoa Oct 21, 2024
254f49a
regolded GA that did not print final solution (when the optimization …
alfoa Oct 21, 2024
90536b0
Update ravenframework/Steps/MultiRun.py
alfoa Oct 21, 2024
2b68e5c
if the printing is done, don't print
alfoa Oct 23, 2024
ff47a1a
Merge branch 'alfoa/fixOptimizerWriteStepFinal' of github.com:idahola…
alfoa Oct 23, 2024
39c5a39
xml
alfoa Oct 23, 2024
e8b15fd
Update tests/framework/Optimizers/GeneticAlgorithms/discrete/unconstr…
alfoa Oct 23, 2024
5fe5932
test pinned library
alfoa Oct 25, 2024
c1bdd2f
Merge branch 'alfoa/fixOptimizerWriteStepFinal' of github.com:idahola…
alfoa Oct 25, 2024
d9c9dcc
trying with 5.1.0
alfoa Oct 28, 2024
57d648c
trying version of ray and redis that worked on windows
alfoa Oct 31, 2024
50828f1
trying version of ray and redis that worked on windows
alfoa Oct 31, 2024
e63c1e2
changed approach to fix the issue. This is much cleaner and less conf…
alfoa Nov 6, 2024
3164cbc
Apply suggestions from code review
alfoa Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dependencies.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Note all install methods after "main" take
<dask source="pip" pip_extra="[complete]"/>
<ray source="pip" pip_extra="[default]">2.6</ray>
<!-- redis is needed by ray, but on windows, this seems to need to be explicitly stated -->
<redis source="pip" os='windows'/>
<redis source="pip" os='windows'>5.1</redis>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because redis released a new version on Oct 24 2024 (5.2) and this new version is not compatible with ray 2.6 (causing the Windows test to fail).

See https://pypi.org/project/redis/#history

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well changing the dependency does not help.... @joshua-cogliati-inl no idea

<imageio source="pip">2.22</imageio>
<line_profiler optional='True'/>
<!-- <ete3 optional='True'/> -->
Expand Down