fix optimizer writeStep final (if optimization ends for reaching the limit number of iterations)

ravenframework/Models/Code.py

@@ -529,6 +529,7 @@ def evaluateSample(self, myInput, samplerType, kwargs):
     sampleDirectory = os.path.join(os.getcwd(),metaData['subDirectory'])
     localenv = dict(os.environ)
     localenv['PWD'] = str(sampleDirectory)
+    os.makedirs(os.path.dirname(os.path.join(sampleDirectory,codeLogFile)), exist_ok=True)
     outFileObject = open(os.path.join(sampleDirectory,codeLogFile), 'w', bufferSize)
 
     found = False

ravenframework/Steps/MultiRun.py

@@ -267,6 +267,12 @@ def _localTakeAstepRun(self, inDictionary):
     # END while loop that runs the step iterations (collection and submission-for-DET)
     # if any collected runs failed, let the sampler treat them appropriately, and any other closing-out actions
     sampler.finalizeSampler(self.failedRuns)
+    for myLambda, outIndex in self._outputCollectionLambda:
+      if isinstance(outputs[outIndex], OutStreamEntity):
+        myLambda([None,outputs[outIndex]])
+        self.raiseAMessage(f'Just collected job {finishedJob.identifier} and sent to output "{inDictionary["Output"][outIndex].name}"')
+
+
 
   def _addNewRuns(self, sampler, model, inputs, outputs, jobHandler, inDictionary, verbose=True):
     """

tests/framework/Optimizers/GeneticAlgorithms/discrete/unconstrained/testGAMaxwoRepConvAHDp.xml

@@ -11,6 +11,9 @@
       The objective variable is ans. The problem in unconstrained, it is a maximization problem, and the sampling is from discrete variables without replacement.
       The convergence criterion used is the (p-Average Hausdorff Distance between populations) AHDp.
     </description>
+    <revisions>
+      <revision author="alfoa" date="2024-10-21">Modified writeSteps to ``final'' to makes sure the Outstream is executed and the final solution is always written. Closes #2386</revision>
+    </revisions>
     <analytic>
       This test uses myLocalSum's analytic objective function.
     </analytic>