-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update LOGOS submodule ID #2110
Conversation
@dylanjm Here is the PR for LOGOS dependencies update (remove the pined version for pyomo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
Job Mingw Test on 5fad4bb : invalidated by @dylanjm Timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to a new version of LOGOS on branch devel.
Job Mingw Test on 5fad4bb : invalidated by @joshua-cogliati-inl Timeout tests/framework/pca_adaptive_sgc/test_adaptive_sgc_poly_pca_analytic |
@joshua-cogliati-inl @dylanjm I guess we do not need to wait the regression tests to be finished. Since it is submodule updates, and the only update is to remove the pined version for pyomo. Let me know what do you think. |
@wangcj05 Yeah, I say we go for it. |
Job Mingw Test on 5fad4bb : canceled by @wangcj05 library update only, will be tested in HERON submodule ID update. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
see #1114
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.