Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute both signs, and check both, since one will work. #1940

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Aug 10, 2022

Either sign is possible, so calculate both, and so we expect one failure,
but if both fail, then the calculation is wrong.


Pull Request Description

What issue does this change request address?

#1806

What are the significant changes in functionality due to this change request?

It is possible for these crow tests to calculate one of two possible signs, so calculate both possibilities, and
one of them should work.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Either sign is possible, so calculate both, and so we expect one failure,
but if both fail, then the calculation is wrong.
@moosebuild
Copy link

Job Mingw Test on 5828c88 : invalidated by @joshua-cogliati-inl

failed in fetch

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change are good. Suggestion for future, we may need to design a better way to check the consistence.

@wangcj05
Copy link
Collaborator

changes look good, and checklist is satisfied.

@wangcj05 wangcj05 merged commit ecd7c67 into idaholab:devel Aug 10, 2022
@joshua-cogliati-inl joshua-cogliati-inl deleted the both_signs branch August 10, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants