Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workshop materials #796

Closed
10 tasks done
wangcj05 opened this issue Sep 20, 2018 · 5 comments · Fixed by #800
Closed
10 tasks done

update workshop materials #796

wangcj05 opened this issue Sep 20, 2018 · 5 comments · Fixed by #800
Assignees
Labels
priority_critical task This tag should be used for any new capability, improvement or enanchment

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Sep 20, 2018


Issue Description

What did you expect to see happen?

The workshop should be up to date.

EDIT @alfoa : All the inputs in the workshop material should be part of our regression test system.

What did you see instead?

It is quite old now

Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 added priority_critical task This tag should be used for any new capability, improvement or enanchment labels Sep 20, 2018
@wangcj05 wangcj05 self-assigned this Sep 20, 2018
@alfoa
Copy link
Collaborator

alfoa commented Sep 20, 2018

@wangcj05 I added the following sentence as well:
All the inputs in the workshop material should be part of our regression test system.

@wangcj05 wangcj05 mentioned this issue Sep 20, 2018
8 tasks
@alfoa
Copy link
Collaborator

alfoa commented Sep 27, 2018

Closure checklist passed....

@wangcj05
Copy link
Collaborator Author

wangcj05 commented Sep 27, 2018

Email regarding this is sent to raven users, and the proposed email is:

Dear Users,
We recently realized that some tests for the RAVEN workshops are outdated and can not be executed. This issue has been resolved with PR#800 and is the modifications are currently available in the devel branch. Now all the tests under raven/doc/workshop are tested in the regression test systems. In this case, all the tests will be updated with any changes we made in the our devel branch.

Please let us know if you have any questions regarding these changes.

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Sep 27, 2018

Could we put a more positive spin on that, or did it already send?

If we highlighted more than "all workshop materials have been updated to the current RAVEN version and are tested in the regression system" instead of "we noticed a bunch weren't working", maybe that would highlight the contribution more?

@wangcj05
Copy link
Collaborator Author

wangcj05 commented Sep 27, 2018 via email

This was referenced Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_critical task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants