Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistorySetSampling does not handle the HistorySet correctly #739

Closed
10 tasks done
wangcj05 opened this issue Aug 8, 2018 · 1 comment · Fixed by #746
Closed
10 tasks done

HistorySetSampling does not handle the HistorySet correctly #739

wangcj05 opened this issue Aug 8, 2018 · 1 comment · Fixed by #746

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Aug 8, 2018


Issue Description

What did you expect to see happen?

For given HistorySet, the code should run successfully.

What did you see instead?
The code crashed:
Traceback (most recent call last):
  File "/Users/wangc/projects/wangc/raven/framework/Driver.py", line 281, in <module>
    raven()
  File "/Users/wangc/projects/wangc/raven/framework/Driver.py", line 234, in raven
    simulation.run()
  File "/Users/wangc/projects/wangc/raven/framework/Simulation.py", line 798, in run
    stepInstance.takeAstep(stepInputDict)
  File "/Users/wangc/projects/wangc/raven/framework/Steps.py", line 312, in takeAstep
    self._localTakeAstepRun(inDictionary)
  File "/Users/wangc/projects/wangc/raven/framework/Steps.py", line 466, in _localTakeAstepRun
    model.collectOutput(finishedJob,output)
  File "/Users/wangc/projects/wangc/raven/framework/Models/PostProcessor.py", line 240, in collectOutput
    self.interface.collectOutput(finishedjob,output)
  File "/Users/wangc/projects/wangc/raven/framework/PostProcessors/InterfacedPostProcessor.py", line 198, in collectOutput
    output.load(evaluation['data'], style='dict', dims=evaluation['dims'])
  File "/Users/wangc/projects/wangc/raven/framework/DataObjects/DataSet.py", line 435, in load
    self._fromDict(fileName,**kwargs)
  File "/Users/wangc/projects/wangc/raven/framework/DataObjects/DataSet.py", line 1257, in _fromDict
    self.asDataset()
  File "/Users/wangc/projects/wangc/raven/framework/DataObjects/DataSet.py", line 260, in asDataset
    return self._convertToXrDataset()
  File "/Users/wangc/projects/wangc/raven/framework/DataObjects/DataSet.py", line 1074, in _convertToXrDataset
    raise e
ValueError: setting an array element with a sequence.
Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@alfoa
Copy link
Collaborator

alfoa commented Sep 6, 2018

The issue does not cause bad results but a crash of the code... No email needed.

Closure checklist passed...

@alfoa alfoa closed this as completed in #746 Sep 6, 2018
alfoa pushed a commit that referenced this issue Sep 6, 2018
* update dict converstion in DataSet, fix HistorySetSampling

* update test and regold for issue #739

* remove unused xml files

* PointSet is handled differently in the _convertToDict of DataSets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants