Dont try to run tests using the XDR format when libmesh was built without it #28992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout it refs idaholab#26682 fixes failures found in idaholab#28906
|
Job Documentation, step Docs: sync website on 4127d5a wanted to post the following: View the site here This comment will be updated on new commits. |
lindsayad
previously approved these changes
Nov 2, 2024
|
seems I imagined this parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #26682
fixes failures found in #28906
I think the error message is clear enough for someone USING xdr when they built without support for it that we dont need to make their test suite fail as well. But I could be wrong.
In which case we could keep only 1 failing test?