Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD workflow documentation #73

Open
wants to merge 16 commits into
base: devel
Choose a base branch
from
Open

CAD workflow documentation #73

wants to merge 16 commits into from

Conversation

meltawila
Copy link
Collaborator

This PR is to add CAD-based Geometry Workflow example for Multiphysics Fusion Problems Using OpenMC and MOOSE. Work and results taken from M. Eltawila, A. J. Novak, P.C. A. Simon, G. Giudicelli, D. Gaston, “Investigating CAD-based Geometry Workflows for Multiphysics Fusion Problems Using OpenMC and MOOSE,” Submitted to Pacific Basin Nuclear Conference (PBNC) (2024).

(Ref. #30)

@moosebuild
Copy link
Contributor

moosebuild commented Oct 7, 2024 •
edited
Loading

Job Documentation, step Sync to remote on 44f8da3 wanted to post the following:

View the site here

This comment will be updated on new commits.

cticenhour
cticenhour requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment I wanted to note, before this gets to formal review. CIVET is throwing a warning that this PR is too large (storage-wise), and I agree. We should work toward a minimum usable size for image files (doc/content/figures/cad_workflow_d1.png and doc/content/figures/cad_workflow_mesh_1.png are notable examples), and a minimum testable size for gold files.

@meltawila
Copy link
Collaborator Author

@cticenhour Should I omit Exodiff tests and only use Csvdiff instead to reduce /gold size?

@meltawila
Copy link
Collaborator Author

@loganharbour I think CIVET should call cardinal/scripts/download-openmc-cross-sections.sh here and set OPENMC_CROSS_SECTIONS similar to what happens for Cardinal. Could you help with this please?

loganharbour
loganharbour requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@loganharbour loganharbour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the moose submodule update. XS should be good to go now

@meltawila meltawila force-pushed the CAD_workflow branch 2 times, most recently from 930fd37 to ee2690d Compare December 6, 2024 15:02
@moosebuild
Copy link
Contributor

Job Precheck, step Size check on 44f8da3 wanted to post the following:

Warning: This PR changes repo size by 5.09 MiB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganharbour loganharbour loganharbour requested changes

@cticenhour cticenhour cticenhour requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meltawila @moosebuild @cticenhour @loganharbour