Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Contribution Documentation #3

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add Code Contribution Documentation #3

merged 3 commits into from
Nov 15, 2023

Conversation

cticenhour
Copy link
Member

This PR takes @simopier's contributing guidelines, makes some adjustments to add more information on code standards, cloning, and git remotes, and then formats it using proper MooseDown. A link is provided for this page from the navigation bar.

Refs #2

cticenhour and others added 2 commits November 9, 2023 09:18
Refs #2

Co-authored-by: Pierre-Clément Simon <PierreClement.Simon@inl.gov>
@moosebuild
Copy link
Contributor

moosebuild commented Nov 9, 2023

Job Documentation on 5a9505a wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Nov 9, 2023

Job Coverage on 5a9505a wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@cticenhour
Copy link
Member Author

Tagging @loganharbour to give input on the coverage generation failure. I invalidated once as a double-check, but this made no difference.

Copy link
Collaborator

@simopier simopier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cticenhour for this contribution! And thank you @loganharbour for getting me access to the doc.

I only have small edits. I wasn't able to figure out how to make some of my suggestions clear due to the ambiguity of the triple '`'. Sorry about that.

doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
doc/content/sqa/contributing.md Outdated Show resolved Hide resolved
@cticenhour cticenhour requested a review from simopier November 14, 2023 16:55
Copy link
Collaborator

@simopier simopier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@simopier simopier merged commit d341317 into idaholab:devel Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants