Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing the issue of #145 on kernels and postprocessors missing for RTES simulation #146

Open
wants to merge 3,041 commits into
base: devel
Choose a base branch
from

Conversation

wjin33
Copy link
Collaborator

@wjin33 wjin33 commented Sep 12, 2024

Add kernels and postprocessors for RTES work

moosetest added 30 commits July 19, 2022 14:08
@wjin33 wjin33 changed the title #145 Addressing the issue of #145 on kernels and postprocessors missing for RTES simulation Sep 12, 2024
@moosebuild
Copy link

Job Test on c216d7c wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on c216d7c wanted to post the following:

Coverage

13ac82 #146 c216d7
Total Total +/- New
Rate 86.16% 63.34% -22.82% 0.00%
Hits 1301 1301 - 0
Misses 209 753 +544 544

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on c216d7c wanted to post the following:

The following coverage requirement(s) failed:

  • Coverage rate 63.34% is less than the required 85.0%

@wjin33
Copy link
Collaborator Author

wjin33 commented Sep 18, 2024

@moosebuild, do you know how can I revise the code so it can pass the Coverage issue?

@rpodgorney
Copy link
Collaborator

@wjin33 create a new branch and call it "RTES", then commit all your changes there. It should go through without needing all the coverage.

@loganharbour suggested this path forward

@wjin33
Copy link
Collaborator Author

wjin33 commented Oct 4, 2024

@rpodgorney, @loganharbour, to confirm, should I create an RTES branch on my repo and merge it to the INL falcon devel branch, or should someone create a new branch called RTES in INL/falcon and merge mine to the new branch?

@rpodgorney
Copy link
Collaborator

rpodgorney commented Oct 4, 2024 via email

@wjin33
Copy link
Collaborator Author

wjin33 commented Oct 4, 2024

I checked it. I am not the "admin" of this repo, so I cannot create a new branch on Idaho lab/falcon. I need someone to help.

@rpodgorney
Copy link
Collaborator

Let me see if I can

@rpodgorney
Copy link
Collaborator

@wjin33 I just created a branch called RTES—you should be able to commit your RTES code to it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants