-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing the issue of #145 on kernels and postprocessors missing for RTES simulation #146
base: devel
Are you sure you want to change the base?
Conversation
Adding all kernels customzied from Wencheng Jin for RTES work
@moosebuild, do you know how can I revise the code so it can pass the Coverage issue? |
@wjin33 create a new branch and call it "RTES", then commit all your changes there. It should go through without needing all the coverage. @loganharbour suggested this path forward |
@rpodgorney, @loganharbour, to confirm, should I create an RTES branch on my repo and merge it to the INL falcon devel branch, or should someone create a new branch called RTES in INL/falcon and merge mine to the new branch? |
The later—make a new RTES branch on idaholab/falcon
—sent from my mobile device, please excuse typos or autocorrect errors
Robert Podgorney, PhD, PG
Directorate Fellow, Subsurface Science
Energy and Environment Science and Technology
Idaho National Laboratory
***@***.*** | 208-526-1524
…________________________________
From: Wencheng Jin ***@***.***>
Sent: Thursday, October 3, 2024 6:04:57 PM
To: idaholab/falcon ***@***.***>
Cc: Robert K. Podgorney ***@***.***>; Mention ***@***.***>
Subject: Re: [idaholab/falcon] Addressing the issue of #145 on kernels and postprocessors missing for RTES simulation (PR #146)
@rpodgorney<https://github.com/rpodgorney>, @loganharbour<https://github.com/loganharbour>, to confirm, should I create an RTES branch on my repo and merge it to the INL falcon devel branch, or should someone create a new branch called RTES in INL/falcon and merge mine to the new branch?
—
Reply to this email directly, view it on GitHub<#146 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWGDT3X5SM2C65YA6L65SLZZXLSTAVCNFSM6AAAAABOD2G6PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJSGUZTMMZZG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I checked it. I am not the "admin" of this repo, so I cannot create a new branch on Idaho lab/falcon. I need someone to help. |
Let me see if I can |
@wjin33 I just created a branch called RTES—you should be able to commit your RTES code to it now |
Add kernels and postprocessors for RTES work