Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "public" pseudo-segments for public IP addresses #542

Closed
mmguero opened this issue Aug 15, 2024 · 1 comment
Closed

add "public" pseudo-segments for public IP addresses #542

mmguero opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request logstash Relating to Malcolm's use of Logstash
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Aug 15, 2024

When enriching with netbox, source and destination network segments are populated from IP addresses.

@ee-hex-ee requested that we also put in "public" for a pseudo-segment (pseudo because it won't actually exist in netbox) for public IP addresses, so it will work in things like sankey diagrams.

Should it populate the cross-segment tag?

@mmguero mmguero added enhancement New feature or request logstash Relating to Malcolm's use of Logstash labels Aug 15, 2024
@mmguero mmguero added this to the z.staging milestone Aug 15, 2024
@mmguero mmguero added this to Malcolm Aug 15, 2024
@mmguero mmguero moved this to Todo (develop) in Malcolm Aug 15, 2024
@mmguero mmguero modified the milestones: z.staging, v24.08.0 Aug 15, 2024
@mmguero mmguero self-assigned this Aug 15, 2024
@mmguero mmguero moved this from Todo (develop) to In Progress in Malcolm Aug 15, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 15, 2024
@mmguero mmguero moved this from In Progress to Testing in Malcolm Aug 15, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 15, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 15, 2024
@mmguero
Copy link
Collaborator Author

mmguero commented Aug 15, 2024

Done. cross_segment tag is set, source.segment.name and/or destination.segment.name will be set to public when applicable.

@mmguero mmguero closed this as completed Aug 15, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in Malcolm Aug 15, 2024
This was referenced Aug 20, 2024
@mmguero mmguero moved this from Done to Released in Malcolm Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logstash Relating to Malcolm's use of Logstash
Projects
Status: Released
Development

No branches or pull requests

1 participant