Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional service argument to restart script #521

Closed
mmguero opened this issue Jul 24, 2024 · 1 comment
Closed

add optional service argument to restart script #521

mmguero opened this issue Jul 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Jul 24, 2024

The ./scripts/restart script (which is a symlink to control.py) currently just does a stop and then a start operation on the entire system.

It would be good if we modified control.py to be able to handle the -s/--service argument like we have for logs, and in that case only restart the one service. So:

  • ./scripts/restartrestarts Malcolm
  • ./scripts/restart -s api restarts just the API container

This came from this discussion.

@mmguero mmguero added the enhancement New feature or request label Jul 24, 2024
@mmguero mmguero added this to the v24.07.0 milestone Jul 24, 2024
@mmguero mmguero self-assigned this Jul 24, 2024
@mmguero mmguero added this to Malcolm Jul 24, 2024
@mmguero mmguero moved this to Todo (develop) in Malcolm Jul 24, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jul 24, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Jul 24, 2024
@mmguero
Copy link
Collaborator Author

mmguero commented Jul 24, 2024

You can now specify one or more services with the -s/--service flag for the control.py script (e.g., start, stop, restart, logs) and it will apply only to those services. This is intended to be used while malcolm is already running, for example, to restart just a single service.

I tested making a change to a particular .env file in the config directory and then restarting the appropriate service, and verified that the restarted service does in fact get the new environment variables, as well.

@mmguero mmguero closed this as completed Jul 24, 2024
@github-project-automation github-project-automation bot moved this from Todo (develop) to Done in Malcolm Jul 24, 2024
This was referenced Jul 29, 2024
@mmguero mmguero moved this from Done to Released in Malcolm Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Released
Development

No branches or pull requests

1 participant